Merged
Conversation
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
…ing from config Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
force-pushed
the
fix-snapshot-prune
branch
from
4685dd3 to
c0f3036
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9502 +/- ##
==========================================
- Coverage 49.42% 42.91% -6.51%
==========================================
Files 151 154 +3
Lines 13475 13522 +47
==========================================
- Hits 6660 5803 -857
- Misses 5474 6551 +1077
+ Partials 1341 1168 -173
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
galal-hussein
approved these changes
Mar 1, 2024
vitorsavian
approved these changes
Mar 4, 2024
This was referenced Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
k3s etcd-snapshot prunewith nonexistentetc-snapshot-dirk3s etcd-snapshot prunenot loadingsnapshot-retentionfrom config fileTypes of Changes
bugfix
Verification
See linked issues
Testing
Linked Issues
etcd-snapshot-dirdoes not exist #9316 (comment)User-Facing Change
Further Comments